[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)

On 4 Jul 2006, at 08:48, KUWAMURA Shin'ya wrote:

Where does the magic number '31' come from in the first place? That's
not the number Xen uses. It could conflict with the domain id of a
non-idle domain.

"31" comes from xenmon.py and xenbaked.h.

  #define NDOMAINS 32

Notice that 31 is NDOMAINS-1.

Therefore, xenmon supports only up to 32 domains.

That's poor, since it in fact only really supports the first 31 domains created on a system (domain ids don't necessarily quickly get reused; and 32nd domid is used as sentinel to indicate idle). It shouldn't be hard to use a data structure more complicated than (presumably) a small array indexed by domid.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.