[Xen-devel] Re: [XenPPC] [RFC][PATCH] Isolating ACM's architecture-dependent parts

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-09-13 at 10:53 -0400, Stefan Berger wrote:
> 
> hollisb@xxxxxxxxxxxxxxxxxxxxxxx wrote on 09/13/2006 10:51:29 AM:
> > 
> > Other than that, this patch seems great. 
> 
> Don't want to have that checked in so far, though. 

Why not?

BTW, I missed this first time:

> --- /dev/null
> +++ root/xen-unstable.hg/xen/acm/acm_multiboot.c
> @@ -0,0 +1,2 @@
> +#include <acm/acm_hooks.h>

That is where the (non-inline) ACM/multiboot functions should live; not
in a header file.

> What about the multiboot code. Do you think PPC will be able to also
> use this part? Not that I would move it, it's more out of curiosity. 

Well, that ifdef will need changing. Why must it exist at all, is it
some weirdness of Xen/x86-64?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel