[Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remote hosts

[Muli Ben-Yehuda <muli@xxxxxxxxxx>]

On Wed, Sep 27, 2006 at 10:17:42AM +0100, Keir Fraser wrote:
> On 26/9/06 16:26, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:
> 
> > The attached patch makes xenconsole send and receive console messages
> > over a remote connection, instead of via stdin/stdout - if given the
> > --remote switch. It is useful for proxy'ing real console message or
> > other protocol messages (such as gdb) between dom0 and a remote
> > host. We're currently using it for proxying gdb between gdbstub in a
> > partition that talks gdb over the console page to a remote host
> > running gdb.
> 
> Reconsidering this patch, I think it's okay to put socket connection
> capability into the client. *But*:
>  1. It can't go in until development reopens for 3.0.4.

Sure, that's completely understandable.

>  2. I think the buffering code is not quite there yet. What you want is to
> make all fd's non-blocking, have small (e.g., 1kB) buffers, and then only
> add an fd to the read-set if its buffer is not full,  and only add an fd to
> the write-set if its buffer is not empty. The buffers can stay as ring
> buffers, so a bunch of that code probably stays.

Ok. I think it will end up being more code than what we do right now,
but if you prefer it this way, fine.

>  3. The networking options are confusing. What are the 'remote' and
> 'gateway' options intended for?

--remote = activate the networking.
--gateway = allow connections from any host, not just localhost

suggestions for better names will be appreciated.

> I think that the networking and buffering-fixes parts of the patch should be
> split. We can put in the buffering/select() changes first.

Ok. I'll implement and resubmit in the 3.0.4 timeframe, other things
require my attention for the time being.

Cheers,
Muli

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel