Re: [Xen-devel] [PATCH] BUG() on soft lockup upon suspend/resume

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 9/10/06 10:22 pm, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> In systems with vcpu > 1, a BUG due to a detected soft lockup seems to be
> triggered after system resume/suspend. This is probably due to the lack of
> seqlocking around the region that does the local time processing.

We do SMP save/restore tests regularly and do not see this issue. It ought
to be avoided by the fact that, when we bring up a CPU, we
touch_softlockup_watchdog() in cpu_bringup(), before enabling interrupts.
For CPU0 on resume, the touch is done in time_resume() in
arch/i386/kernel/time-xen.c.

In general that local accounting work does not need to be done under the
xtime_lock. Native x86 does not take the lock in smp_local_timer_interrupt()
(apic.c) for example.

I think we need to understand the issue you are hitting a bit more before
deciding on the right fix.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel