Re: [Xen-devel] [PATCH] Minor fixes for non-Linux platforms

[Aron Griffis <aron@xxxxxx>]

Christoph Egger wrote:  [Thu Oct 12 2006, 08:33:22AM EDT]
> diff -r 49d096ef3d76 tools/check/chk
> --- a/tools/check/chk Fri Oct 13 10:58:29 2006 +0100
> +++ b/tools/check/chk Thu Oct 12 14:31:08 2006 +0200
> @@ -1,18 +1,7 @@
> -#!/bin/bash
> -
> -function usage {
> -    echo "Usage:"
> -    echo "\t$0 [build|install|clean]"
> -    echo
> -    echo "Check suitability for Xen build or install."
> -    echo "Exit with 0 if OK, 1 if not."
> -    echo "Prints only failed tests."
> -    echo
> -    echo "Calling with 'clean' removes generated files."
> -    exit 1
> -}
> +#!/bin/sh
>  
>  export PATH=${PATH}:/sbin:/usr/sbin
> +export OS=`uname -s`

export with variable assignment doesn't work on most Bourne shells.
These need to be split up:

PATH=${PATH}:/sbin:/usr/sbin
OS=`uname -s`
export PATH OS

>  case $1 in
>      build)
> @@ -25,7 +14,15 @@ case $1 in
>          exit 0
>          ;;
>      *)
> -        usage
> +     echo "Usage:"
> +     echo "\t$0 [build|install|clean]"

\t isn't standard (it doesn't even work on Linux without -e).  
You should insert a real tab there instead.

Aron

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel