[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Some comments:

No need for IO-APIC work on the guest side of the kexec interfaces (e.g.,
don't call disable_IO_APIC()).

What's the second argument to the hypercall for? There's no clear
explanation of what the TYPE parameter means, and currently it is only ever
specified as TYPE_CRASH. So what's TYPE_DEFAULT for? And do we really need
to avoid copy_to/from_guest so it can't be folded into the structural
parameter?

The comment attached to every use of xchg() is dubious. We don't specify
warn_unused_result on that function so there's no good reason for the
compiler to complain about discarding the result. If it's a reproducible
problem it needs investigating. We shouldn't work around a broken compiler.

Attribution at the top of many files: 'Horms' is a bit vague. Could we have
a full name? A company name? An email address?

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel