Re: [Xen-devel] [PATCH] Fix tools build on Solaris

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Tue, Oct 17, 2006 at 02:31:46PM +0100, Keir Fraser wrote:

> > Many of the tools use C99 features such as bool, or expect certain 
> > functions.
> > Fix the CFLAGS to enable these on Solaris.
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> Can't you fold TOOL_CFLAGS into CFLAGS? Why do you need a separate variable:
> does it break the hypervisor build?

Yes. It's not at all clear why, but the -std=gnu99 causes:

gcc -O1 -fno-omit-frame-pointer -g -std=gnu99 -D_POSIX_C_SOURCE=200112L
-D__EXTENSIONS__ -Wa,--divide -m64 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common
-fno-strict-aliasing -iwithprefix include -Werror -Wno-pointer-arith
-pipe -I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include
-I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-generic
-I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-default
-msoft-float -mno-red-zone -fpic -fno-reorder-blocks
-fno-asynchronous-unwind-tables -g -D__XEN__ -DVERBOSE  -c domctl.c -o
domctl.o
domctl.c: In function `do_domctl':
domctl.c:173: error: initializer element is not constant

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel