Re: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 18/10/06 1:56 am, "Horms" <horms@xxxxxxxxxxxx> wrote:

>> I'll check this in, so please just get rid of the if(xchg()) hacky
>> workaround.
> 
> I have to say that I entirely disagree with your solution.
> I think the solution is to get rid of -Werror. But I will
> remove the if(xchg()) foo as you request.

Holy crap! Getting rid of Werror makes Wall much less useful. We're too lazy
to scan build output for warnings if they don't break the build.

The GCC developers have basically broken the unused-value checking, at least
for Linux-style code which is heavy on macro usage. If a particular warning
option is no longer useful, the correct answer is to switch it off.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel