Re: [Xen-devel] [PATCH 1/3] Add support for OpenBSD

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 18/10/06 18:08, "John Clemens" <jclemens@xxxxxxxxxxxxxxxxx> wrote:

> I can tell you for a fact that that check doesn't work on Ubuntu edgy.
> 
> 'test-gcc-flag' greps the gcc --help output, which doesn't do the right
> thing, at least on Ubuntu.  I believe the linux kernel equivalent tries
> to actually use the option and checks the gcc return code.
> 
> I was in the midst of tracking this down a few weeks ago when I
> discovered other HVM bugs that apparently only show up with gcc v4 (bad
> EFER values), so I moved back to compiling with gcc-3.4 and dropped it.
> I'll see if I can finish it up and submit a patch unless someone beats
> me to it.

Okay, I checked in something like the Linux cc-option function as
xen-unstable changeset 11820:b2e71d574045. Actually I changed it because
Linux allows through options which aren't really recognised (and cause a
warning to be printed) but which do not cause gcc to return an error code.
Instead I look for any output on stdout/stderr. It should be more robust
than grepping the output of gcc long help!

By the way, the EFER bug was fixed weeks ago.
 
 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel