[Xen-devel] [PATCH] Raise DevError for device not found at blkif.py

[Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>]

Sorry if you get it twice. I have no idea why wasn't it delivered.
Follows:


Anthony,

Hope this is a better error raising for the device not found
construction in blkif.py. I imagine this Error can be used for
generic device-related errors during Vm Construction.

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

--- xen-3.0.3-testing-11633/tools/python/xen/xend/XendError.py.orig     
2006-10-20 08:09:50.000000000 -0400
+++ xen-3.0.3-testing-11633/tools/python/xen/xend/XendError.py  2006-10-20 
08:11:36.000000000 -0400
@@ -36,4 +36,7 @@ class VmError(XendError):
     """Vm construction error."""
 
     pass
+class DevError(VmError):
+    """Device probing/constructing"""
 
+    pass
--- 
xen-3.0.3-testing-11633/tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py.orig
       2006-09-28 18:52:39.000000000 -0400
+++ 
xen-3.0.3-testing-11633/tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py
    2006-10-20 08:23:53.000000000 -0400
@@ -23,7 +23,7 @@ import string
 from xen.util import blkif
 from xen.util import security
 from xen.xend import sxp
-from xen.xend.XendError import VmError
+from xen.xend.XendError import VmError,DevError
 
 from xen.xend.server.DevController import DevController
 
@@ -81,6 +81,9 @@ class BlkifController(DevController):
                          'acm_policy' : policy})
 
         devid = blkif.blkdev_name_to_number(dev)
+        if not devid:
+            raise DevError('Unable to find number for device (%s)'%(dev))
+
         front = { 'virtual-device' : "%i" % devid,
                   'device-type' : dev_type
                 }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel