Re: [Xen-devel] [patch] Fix 32bit xen-tools build.

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 20/10/06 1:25 pm, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> -CFLAGS += -m32 -march=i686
>> -LIBDIR := lib
>> +CFLAGS  += -m32 -march=i686
>> +LDFLAGS += -m32
>> +ASFLAGS += -m32
>> +LIBDIR  := lib
> 
> Where is left that needs LDFLAGS/ASFLAGS to have the -m flags? It's
> wrong anyway, there should be nowhere that's not using $CFLAGS; see the
> previous discussion. We've had to disable a couple of directories for
> now, so probably it's in one of those?

Bit more context: anywhere that *is* using $(LD) directly should add
$(LDFLAGS_DIRECT) to the command line. This adds -mi386 or -mx86_64. The
linker does not understand -m32/-m64. But anywhere not doing tricky links
(e.g., with a GNU-specific script) should call the linker via the GCC
driver.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel