Re: [Xen-devel] [PATCH] Stop enforcing -g for some of the tools.

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, John

I have small questions.

The following option is  written in $(XEN_ROOT)/Config.mk.
=====================
ifneq ($(debug),y)
CFLAGS += -DNDEBUG
else
CFLAGS += -g
endif
=====================

So I think tools is compiled with -g by default if your patch is applied.
Am I right?

>diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
>--- a/tools/xenstore/Makefile
>+++ b/tools/xenstore/Makefile
>@@ -6,7 +6,7 @@ MINOR = 0
> MINOR = 0
> 
> PROFILE=#-pg
>-BASECFLAGS=-Wall -g -Werror
>+BASECFLAGS=-Werror
> # Make gcc generate dependencies.
> BASECFLAGS += -Wp,-MD,.$(@F).d
> PROG_DEP = .*.d
Why do you remove -Wall?

Best Regards,

Akio Takebe


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel