[Xen-devel] Re: [PATCH] Fix >4G i386 PAE grant table interface

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 02.11.06 19:16 >>>
>On 2/11/06 16:53, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:
>
>> This patch updates both the linux-2.6-sparse tree and the xen HV to use
>> uint64_t instead of unsigned long for those particular functions.  This
>> patch has been tested on RHEL5 Beta on a box with 12G i386.
>> 
>> Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
>
>Nasty bug. At least it affects only blktap. Thanks.

Looking at this it would seem to me that the second call to
gnttab_set_unmap_op in blkltap.c is missing the
GNTMAP_contains_pte flag, affecting auto_translated_physmap
guests. 

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2006-10-30/drivers/xen/blktap/blktap.c
===================================================================
--- head-2006-10-30.orig/drivers/xen/blktap/blktap.c    2006-10-26 
12:10:54.000000000 +0200
+++ head-2006-10-30/drivers/xen/blktap/blktap.c 2006-11-03 10:00:44.000000000 
+0100
@@ -908,8 +908,10 @@ static void fast_flush_area(pending_req_
                                return;
                        }
 
-                       gnttab_set_unmap_op(&unmap[invcount],
-                                           ptep, GNTMAP_host_map,
+                       gnttab_set_unmap_op(&unmap[invcount], ptep,
+                                           GNTMAP_host_map
+                                           | GNTMAP_application_map
+                                           | GNTMAP_contains_pte,
                                            khandle->user);
                        invcount++;
                }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel