Re: [Xen-devel] bug? hvm builder memory allocation ...

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Error handling in xc_domain_{increase,decrease}_reservation() was broken.
With that fixed the HVM builder was indeed broken, so I removed the
unnecessary decrease_reservation() call. This is all fixed in c/s
12273:5a41ea282c.

 Thanks,
 Keir

On 7/11/06 11:41, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

> Well clearly it works. I'm not sure why though. :-) The
> decrease_reservation() request ought to fail and hence fail the HVM guest
> creation. I'll look into it.
> 
>  -- Keir
> 
> On 7/11/06 11:34, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:
> 
>>   Hi,
>> 
>> hvm memory allocation looks buggy in unstable:  First it allocates
>> memory using two xc_domain_memory_populate_physmap() calls, explicitly
>> excluding the vga hole, then the (not allocated) vga hole is released
>> via xc_domain_memory_decrease_reservation() ...
>> 
>> cheers,
>>   Gerd
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel