Re: [Xen-devel] [PATCH] remove HVM halt timer

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 10/11/06 8:04 am, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> remove HVM halt timer.
> It's no longer needed since interrupts can wake it up now; using
> vcpu_unblock instead of vcpu_kick because timer callback functions are
> executed on the precossor the target vcpu is on.

Why do you replace use of the schedop_block hypercall with direct setting of
the blocked flag and softirq? Also vcpu_kick() has negligible extra cost
compared with vcpu_unblock() and it's less confusing just to use it
everywhere. Most people don't remember the semantic difference.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel