Re: [Xen-devel] Fix core dumps of guests > 2 GB in size on i386

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15/11/06 22:02, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

> The attached patch adds the O_LARGEFILE flag when opening the file. It
> is also neccessary to add additional CFLAGS & LDFLAGS to enable use of
> the POSIX Largefile  standard.  There are two ways to enable LFS support,
> in implicit mode all types, functions & macros are automatically changed
> to the 64 bit variants at compile time - this however changes the ABI
> contract - eg size_t is now 64-bits instead of 32.

I like the implicit method. I think it's unlikely to bite us. A lot of tools
subdirs are defining _FILE_OFFSET_BITS=64 anyway (and not using getconf!).
I'll provide a portable common CFLAGS/LDFLAGS addition in tools/Rules.mk.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel