Re: [Xen-devel] [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unstable-12502)

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 28/11/06 6:24 pm, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:

> You define a per CPU variable crash_notes and on crash you loop over
> NR_CPUS and clear the notes for CPUS which don't exist. Unfortunately
> the percpu regions for CPUs which aren't physically present is returned
> to the heap on boot (see percpu_free_unused_areas) -- this means that
> you zero out heap pages on crash :-(
> 
> You need to use num_{possible,present,online}_cpus() in
> machine_crash_kexec() and kexec_get_cpu() instead of NR_CPUS.

You should use for_each_cpu, for_each_present_cpu, or for_each_online_cpu.
Probably the last of those unless you care about dormant CPUs or hotplugged
CPU sockets. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel