[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] [XENOPROF] fix shared_xenoprof_page_with_guest() and clean up


  • To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Woller, Thomas" <thomas.woller@xxxxxxx>
  • Date: Tue, 28 Nov 2006 17:32:44 -0600
  • Delivery-date: Tue, 28 Nov 2006 15:33:20 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccSxmyMgOdYMfAeSv2ZfgZjDP2wnwAflHXA
  • Thread-topic: [Xen-devel] [PATCH] [XENOPROF] fix shared_xenoprof_page_with_guest() and clean up

Isaku,
When xenoprof is enabled in the 64bit linux dom0, then during the build,
the xenoprof.h include file is not found, and dom0 fails to build with
an error.
It looks like there is no soft link to the i386 version created, but I
am not sure of all of your cleanup modifications and how the build
should actually occur using the i386 xenoprof.h file for x86_64 build. 
Can you provide fix? 
Thanks,
Tom 

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Isaku Yamahata
> Sent: Tuesday, November 28, 2006 2:20 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH] [XENOPROF] fix 
> shared_xenoprof_page_with_guest() and clean up
> 
> 
> Without this patch, profiling more than twice causes xen 
> panic because of page reference counter inconsistency.
> 
> [XENOPROFILE] fix shared_xenoprof_page_with_guest() and clean up.
> - share_xenoprof_page_with_guest() must check page reference 
> count manually
>   and clear the page owner in order to keep page_info consistency.
>   free_domheap_pages() called by put_page() doesn't clear page owner.
>   It's intentional. On the other hand, 
> share_xen_page_with_guest() checks
>   whether the page owner is already a requested one at first. If so,
>   it simply returns doing nothing because 
> share_xen_page_with_guest() expects
>   freshly allocated pages or already shared one and doesn't expect
>   put_page()-and-free_domheap_pages() pages or pages shared with
>   another domains.
> - clean up
>   remove unsed argument gmaddr of alloc_xenoprof_buf(), 
> alloc_xenoprof_struct()
> 
> --
> yamahata
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.