[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 30 Nov 2006 12:56:30 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 30 Nov 2006 04:54:57 -0800
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

>There's code, which use inline functions on function pointers.
>This is IMO a bug.

I disagree - inline is a hint, not a requirement (other than one might say
about __attribute__((__always_inline__)), or when functions are declared/
defined extern inline). Hence I would expect the compiler to generate
out-of-line instances when addresses of the function are taken. Have
you brought this up with the gcc folks?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions
  - From: Christoph Egger

Prev by Date: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions
Next by Date: [Xen-devel] Re: [Qemu-devel] qemu/pci: Unaligned config read/write overflow
Previous by thread: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions
Next by thread: [Xen-devel] Xen boot error
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.