Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a

[Brendan Cully <brendan@xxxxxxxxx>]

On Tuesday, 05 December 2006 at 23:21, Ewan Mellor wrote:
> On Tue, Dec 05, 2006 at 12:51:19PM -0800, Brendan Cully wrote:
> 
> > On Monday, 04 December 2006 at 15:59, Brendan Cully wrote:
> > > # HG changeset patch
> > > # User Brendan Cully <brendan@xxxxxxxxx>
> > > # Date 1165276659 28800
> > > # Node ID 013e995e2a6b0c5b237b29211e697b7757e5f94f
> > > # Parent  fd28a1b139dea91b8bfcf06dd233dbdda8f51ff1
> > > [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a
> > > 
> > > Apparently at some point one could attach multiple IP addresses
> > > to a single VIF in the config file. This doesn't address that
> > > feature.
> > > 
> > > Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>
> > 
> > Sorry, I should have included a better description of the problem:
> > 
> > vif = ['ip=xxx.xxx.xxx.xxx'] hasn't worked since 12633 (at least with
> > Xen's nat scripts). The problem is that pre-12633, the IP field
> > returned from the config parser was a list, but now it is a string. So
> > ' '.join(ip) ends up sending 'x x x . x x x . x x x . x x x' to the
> > scripts, which were expecting less whitespace.
> 
> So does your fix mean that multiple IP addresses work again, or can we
> only have one address this way?  I'd prefer to fix the config parser if
> that's what's needed to support multiple IP addresses, since it
> certainly used to work.

This patch only supports a single IP address. It should easy enough to
support a list again, but I didn't see an example of the config file
syntax for multiple IPs. I presume the delimiter isn't ',' or '
'. Perhaps it's ['ip=foo, ip=bar'] ?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel