[Xen-devel] Re: [patch] Add kexec_ops & function pointers

["Magnus Damm" <magnus.damm@xxxxxxxxx>]

Hi Gerd,

On 12/9/06, Gerd Hoffmann <kraxel@xxxxxxx> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxx>
> ---
>  linux-2.6-xen-sparse/arch/i386/kernel/machine_kexec.c   |    2
>  linux-2.6-xen-sparse/arch/x86_64/kernel/machine_kexec.c |    2
>  linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c   |   42 +++++++-
>  linux-2.6-xen-sparse/include/asm-i386/kexec.h           |   14 --
>  linux-2.6-xen-sparse/include/asm-x86_64/kexec.h         |   13 --
>  linux-2.6-xen-sparse/include/linux/kexec.h              |   24 ++--
>  linux-2.6-xen-sparse/kernel/kexec.c                     |   80 +++++++++++-----
>  7 files changed, 110 insertions(+), 67 deletions(-)
This version looks much cleaner. I've tested the code on i386 using
version 12898 and there was one small piece missing, see the attached
patch.

Basically, machine_kexec() should be converted to kexec_ops.kexec() in
two places. The second place is unfortunately located in
linux/kernel/sys.c which does not exist in sparse yet. So that needs
to be resolved somehow.

So apart from that I think the code looks very good. Thanks.

/ magnus

Attachment: kexec_ops-fixes.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel