Re: [Xen-devel] [PATCH] yet another package check (take 2)

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Fri, Dec 15, 2006 at 08:22:06AM +0000, Jan Beulich wrote:

> >>> Ewan Mellor <ewan@xxxxxxxxxxxxx> 14.12.06 18:11 >>>
> >On Thu, Dec 14, 2006 at 04:23:32PM +0000, Jan Beulich wrote:
> >
> >> As before, the file added to tools/check/ must be given exec permission.
> >> 
> >> Now using the approach suggested by Christoph Egger 
> >> <Christoph.Egger@xxxxxxx>.
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> >> 
> >> Index: 2006-12-11/tools/Makefile
> >> ===================================================================
> >> --- 2006-12-11.orig/tools/Makefile 2006-12-04 08:49:57.000000000 +0100
> >> +++ 2006-12-11/tools/Makefile      2006-12-14 14:25:02.000000000 +0100
> >> @@ -36,7 +36,7 @@ all: check
> >>    $(MAKE) ioemu
> >>  
> >>  .PHONY: install
> >> -install: check
> >> +install: check_install
> >>    @set -e; for subdir in $(SUBDIRS-y); do \
> >>            $(MAKE) -C $$subdir $@; \
> >>    done
> >> @@ -58,6 +58,10 @@ distclean: clean
> >>  check:
> >>    $(MAKE) -C check
> >>  
> >> +.PHONY: check_install
> >> +check_install: check
> >> +  $(MAKE) -C check install
> >> +
> >>  .PHONY: check_clean
> >>  check_clean:
> >>    $(MAKE) -C check clean
> >
> >What's this change for?  In tools/check/Makefile, it says not to run make -C
> >check install as part of make install.
> 
> Hmm, I didn't realize this was intentionally not used. For me it simply means 
> I
> can't run Xen tools directly out of the build area (since install.sh does 
> nothing
> but copying things around, there's little point in using it for other than an 
> install into the default (root=/) location. But obviously, when run directly 
> out
> of the build area, the install checks will never get done and I'm ending up
> with a cryptic error message again.

Just run make -C tools/check install.

> As I can't think of a smarter way, I think taking this change will depend on
> whether it's acceptable to the majority to require all install prerequisites 
> to
> be present on build-only machines,

That's certainly not acceptable.  We won't have the bridge-utils on our build
boxes, for instance.

> and whether it is a reasonable
> expectation that at some future point it'll be possible to run multiple Xen
> versions on the same machine (and, as per above comment, directly out of
> the build area).

Why do you want to run them straight out of the build area?  Just do

export DISTDIR=/usr/local/xen-3.0.3
make dist

and you've got everything that you need, right there.  You'll probably have to
fix a few hardcoded paths, but that should be easy.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel