[Xen-devel] Re: [patch/rfc] multiprotocol blkback drivers (32-on-64)

[Gerd Hoffmann <kraxel@xxxxxxx>]

Jan Beulich wrote:
> I understand you favor this over the bi-modal approach I took? Any specific
> advantages? Jan

IMHO the code is more readable and I'd rate the chance to be accepted by
lkml review higher.  I don't like the approach to hide alot of the logic
in preprocessor magic.

It leaves the door open to add more protocols.  Not that I see a need
right now.  But maybe the lkml folks ask us to consolidate to some
struct layout which doesn't look different on different architectures
(i.e. sort struct members by size), then we maybe have to support a
third protocol ...

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel