Re: [Xen-devel] [PATCH] make balloon driver not return pages which are in [xen_start_info->nr_pages, max_pfn] on ia64

[Alex Williamson <alex.williamson@xxxxxx>]

Hi Keir,

   Any comments on this one?  With this and the patches we already have
in the xen-ia64-unstable tree we can eliminate our current dom0 memory
restrictions on ia64 (ie. allowing dom0 to have more that 1-2GB of
memory).  Thanks,

        Alex

On Thu, 2007-01-04 at 18:06 +0900, Isaku Yamahata wrote:
> make balloon driver not return pages which are in
> [xen_start_info->nr_pages, max_pfn] on ia64.
> On ia64 memory might be assigned sparsely. In that case
> xen_start_info->nr_pages and max_pfn doesn't match while pages which
> are in
> [xen_start_info->nr_pages, max_pfn] are used.
> 
> -- 
> yamahata
> 

> # HG changeset patch
> # User yamahata@xxxxxxxxxxxxx
> # Date 1166688432 -32400
> # Node ID 222d8ad625624a4880d63c40d46907cd3ce23d86
> # Parent  407401ea3792efe50b713381e62ef59d3b0964fe
> make balloon driver not return pages which are in
> [xen_start_info->nr_pages, max_pfn] on ia64.
> On ia64 memory might be assigned sparsely. In that case
> xen_start_info->nr_pages and max_pfn doesn't match while pages which
> are in
> [xen_start_info->nr_pages, max_pfn] are used.
> PATCHNAME: fix_balloon_init
> 
> Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
> 
> diff -r 407401ea3792 -r 222d8ad62562
> linux-2.6-xen-sparse/drivers/xen/balloon/balloon.c
> --- a/linux-2.6-xen-sparse/drivers/xen/balloon/balloon.c        Thu
> Dec 21 15:36:31 2006 +0900
> +++ b/linux-2.6-xen-sparse/drivers/xen/balloon/balloon.c        Thu
> Dec 21 17:07:12 2006 +0900
> @@ -446,8 +446,10 @@ static struct notifier_block xenstore_no
>  
>  static int __init balloon_init(void)
>  {
> +#ifndef __ia64__
>         unsigned long pfn;
>         struct page *page;
> +#endif
>  
>         if (!is_running_on_xen())
>                 return -ENODEV;
> @@ -477,12 +479,14 @@ static int __init balloon_init(void)
>  #endif
>         balloon_sysfs_init();
>      
> +#ifndef __ia64__
>         /* Initialise the balloon with excess memory space. */
>         for (pfn = xen_start_info->nr_pages; pfn < max_pfn; pfn++) {
>                 page = pfn_to_page(pfn);
>                 if (!PageReserved(page))
>                         balloon_append(page);
>         }
> +#endif
>  
>         target_watch.callback = watch_target;
>         xenstore_notifier.notifier_call = balloon_init_watcher;
> 
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel