Re: [Xen-devel] [PATCH 6/7] Fix xm create direct call to XendBootloader

["Daniel P. Berrange" <berrange@xxxxxxxxxx>]

On Fri, Jan 05, 2007 at 05:22:55PM +0000, Ewan Mellor wrote:
> On Fri, Jan 05, 2007 at 04:53:17PM +0000, John Levon wrote:
> 
> > 
> > Fix xm create direct call to XendBootloader
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> > 
> > diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py
> > --- a/tools/python/xen/xm/create.py
> > +++ b/tools/python/xen/xm/create.py
> > @@ -719,8 +719,11 @@ def run_bootloader(vals, config_image):
> >               "--entry= directly.")
> >          vals.bootargs = "--entry=%s" %(vals.bootentry,)
> >  
> > +    kernel = sxp.child_value(config_image, 'kernel')
> > +    ramdisk = sxp.child_value(config_image, 'ramdisk')
> > +    args = sxp.child_value(config_image, 'args')
> >      return bootloader(vals.bootloader, file, not vals.console_autoconnect,
> > -                      vals.bootargs, config_image)
> > +                      vals.bootargs, kernel, ramdisk, args)
> >  
> >  def make_config(vals):
> >      """Create the domain configuration.
> 
> Surely there's no reason for xm to be running the bootloader directly?!  That
> doesn't make any sense.  Can't we just delete all of this code

Doesn't xm have to be able to run the bootloader if you want the graphical 
menu view to let the user choose the kernel - if you run bootloader 
server-side then it will only ever use the default configured kernel.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel