[Xen-devel] Re: [PATCH] Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2007-01-10 at 17:42 +0900, Magnus Damm wrote:
> Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)
> 
> Kdump has been broken since xen-3.0.4-testing.hg-13109.
> Many thanks to Hiromichi Itou for tracking this down.
> 
> Signed-Off-By: Magnus Damm <magnus@xxxxxxxxxxxxx>

I applied a similar fix to xen-unstable.hg in 13282:9865145e53eb. I'll
get it pulled into xen-3.0.4-testing.hg.

> --- 0001/xen/common/lib.c
> +++ work/xen/common/lib.c     2007-01-10 11:18:38.000000000 +0900
> @@ -442,7 +442,7 @@ s64 __moddi3(s64 a, s64 b)
>  unsigned long long parse_size_and_unit(const char *s, const char **ps)
>  {
>       unsigned long long ret;
> -     const char *s1;
> +     const char *s1 = NULL;
>  
>       ret = simple_strtoull(s, &s1, 0);

Are you sure this bit is necessary? simple_strtoull always initialises
&s1.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel