Re: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 10/1/07 01:18, "S.ÃaÄlar Onur" <caglar@xxxxxxxxxxxxx> wrote:

> Attached patch adds "-Wno-always-true" CFLAGS into xen/arch/powerpc/Rules.mk
> and xen/arch/x86/Rules.mk, else compiling xen with latest gcc-4.2.0 snapshot
> fails, patch is against current xen-3.0.4-testing repo;

If that is the *only* build error, then we can just get rid of that
BUG_ON(). It doesn't work any more anyway (that symbol is never zero, even
during initial kernel link when no symbol info is available).
BUG_ON(symbols_num_syms == 0) is probably the right replacement.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel