Re: [Xen-devel] [PATCH] trivial simplifcation in xen/arch/x86/mm.c

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 10/1/07 09:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Replace mfn_to_page(lXe_get_pfn()) by lXe_get_page().
> 
> However, what I got surprised by while looking for all of these is that
> ptwr_emulated_update() uses gmfn_to_mfn() on the pte loaded from the
> emulation context, while ptwr_do_page_fault() doesn't on the pte stored
> into that context. Shouldn't these two be symmetric?
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Yes. Shadow_mode_translate without shadow_mode_refcount is horribly broken
in various ways, but I'll fix this particular confusion at least.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel