[Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h

["Christoph Egger" <Christoph.Egger@xxxxxxx>]

Hi!

I cleaned up xen/include/asm-x86/guest_access.h. I also fixed a bug in 
__copy_field_from_guest(), which seems to me to
be a kind of cut-copy-paste bug.

copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
argument as the first argument. So I remove the consts from the initializer.
I replace typeof with __typeof__, which is always available in gcc - it is 
not, when the -ansi option is used.

I do some explicit casts, which makes gcc errors more readable.
In case, you pass an array by your mistake, which gets
casted to a char *, then gcc tells you that rather just "invalid initializer".

Christoph

Attachment: xen_guest_access.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel