[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled





On 11/1/07 15:42, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Properly conditionalize two places where compat-only structure fields get
> accessed, and avoid compiler warnings on unused variables in two other
> places.

Should we bother to #ifdef where we don't need to? It's ugly and the
compiler should be able to remove dead code where a condition evaluates to
zero at compile time: we already have IS_COMPAT(d) hardcoded to zero if
!CONFIG_COMPAT, which is enough to give the compiler a fair chance.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.