[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] RFC: vaddr_t and vsize_t



On Wednesday 17 January 2007 17:51, Keir Fraser wrote:
> On 17/1/07 16:21, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > This stuff is about removing a place where programmers can make mistakes.
> > vaddr_t also avoids void * arithmetics. It should be possible then to use
> > -Wpointer-arith.
>
> A bunch of our void* arithmetic comes from files we keep in sync with
> Linux. So we'd really need Linux to clean this up before we use
> -Wpointer-arith, or we have to do extra porting effort to keep files in
> sync.

Well, actually I'm talking about the Xen-kernel and not about the 
Linux-kernel.

> I suppose I don't mind vaddr_t being defined and people using it if they
> want to. At least it is probably clearer that translation to/from char* or
> long to do pointer arithmetic. However, I'm less sure about a wholesale
> conversion of Xen away from use of 'unsigned long'.

Ok. I will prepare a patch. Someone has to make the start. :-)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.