Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
> On 25/1/07 11:04, "Tomonari Horikoshi" <t.horikoshi@xxxxxxxxxxxxxx> wrote:
> 
>> I confirmed the not error because of this correction.
>> Is there a better correction?
> 
> It's along the right lines so I check it in as is. However, you probably
> need to check that you have enough grant entries for worst-case packet
> fragmentation (a packet may require more than one grant). Or start_xmit()
> needs to be able to buffer one packet until it has enough grants to proceed
> with its transmission.

How about making the total number of grant table entries equal the
number of TX slots? That way we won't have to check anything at all.

It also doesn't make sense to have more TX slots than grant table entries.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel