Re: [Xen-devel] [PATCH] Use string bounded functions

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 29/1/07 10:10, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> The attached patch replaces sprintf with snprintf and strncpy with strlcpy.
> 
> There are various cases where no NULL-terminated strings are guaranteed
> and eventual possible overflows. This patch fixes them.
> 
> BTW: Since Xen kernel has its own string functions, can't we just remove
> sprintf() and strncpy()? IMO, Xen should not inherit the historical C relicts.

This makes plenty of sense. Strncpy() in particular is dangerous and
strlcpy() is always preferable. So I'd be happy to see strncat/strncpy die.

There are a few uses remaining (particularly in arch/ia64) that you'll have
to fix first.

And please add 'signed-off-by' attribution when you post patches!

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel