[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Redundant piece of code in xc_hvm_bulid.c


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Guy Zana" <guy@xxxxxxxxxxxx>
  • Date: Wed, 31 Jan 2007 10:42:47 -0500
  • Delivery-date: Wed, 31 Jan 2007 07:42:55 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdFTnTweciyUttvTxaHyb2jwFnxzQ==
  • Thread-topic: Redundant piece of code in xc_hvm_bulid.c

This piece of code is redundant:
(tools/libxc/xc_hvm_bulid.c) function setup_guest()
 
"""
if ( (v_end - v_start) > ((unsigned long long)nr_pages << PAGE_SHIFT) )
{
    PERROR("Initial guest OS requires too much space: "
           "(%lluMB is greater than %lluMB limit)\n",
           (unsigned long long)(v_end - v_start) >> 20,
           ((unsigned long long)nr_pages << PAGE_SHIFT) >> 20);
    goto error_out;
}
"""
 
Both of the expressions will always have the same value :)
 

Guy Zana.

____________

Team Leader,

Neocleus, Inc.

 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.