Re: [Xen-devel] Reducing impact of save/restore/dump on Dom0

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Tue, Feb 06, 2007 at 10:43:41AM -0500, Graham, Simon wrote:

Index: trunk/tools/libxc/xc_core.c
===================================================================
--- trunk/tools/libxc/xc_core.c (revision 9948)
+++ trunk/tools/libxc/xc_core.c (working copy)
@@ -1,7 +1,13 @@
 #include "xg_private.h"
 #include <stdlib.h>
 #include <unistd.h>
+#include <fcntl.h>
 
+#ifndef O_DIRECT
+#define O_DIRECT 040000
+#endif

O_DIRECT doesn't exist on Solaris. The closest equivalent is
directio(fd, DIRECTIO_ON). Either way you shouldn't be defining it
yourself?

And you should expect this to be able to fail, on Solaris at least.

+    dump_mem_start = mmap(0, PAGE_SIZE*DUMP_INCREMENT, 
+                          PROT_READ|PROT_WRITE, 
+                          MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);

Please use the more portable MAP_ANON.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel