[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0

  • To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 23 Feb 2007 18:43:36 +0000
  • Delivery-date: Fri, 23 Feb 2007 10:43:00 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQAD8etAAABE8FAAAIBJFw==
  • Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0

On 23/2/07 18:32, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

>> 2. You need it in xcutil because this directory has code that includes
>>    xc_private.h -- this seems wrong/bad to me but I wasn't prepared
>>    to change it!
> Actually, it's xcutils/readnotes.c that #include's xg_private.h (which
> in turn includes xc_private.h) -- since the function that does the
> advise call is inline in xc_private.h, this wont compile unless
> _GNU_SOURCE is defined...

Put the Linux definition in xc_linux.c. Put a default dummy implementation
in xc_private.c with __attribute__ ((weak)). If you have only a function
prototype in xc_private.h then you won't need -D_GNU_SOURCE for

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.