Re: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 23/2/07 18:32, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

>> 2. You need it in xcutil because this directory has code that includes
>>    xc_private.h -- this seems wrong/bad to me but I wasn't prepared
>>    to change it!
>> 
> 
> Actually, it's xcutils/readnotes.c that #include's xg_private.h (which
> in turn includes xc_private.h) -- since the function that does the
> advise call is inline in xc_private.h, this wont compile unless
> _GNU_SOURCE is defined...

Put the Linux definition in xc_linux.c. Put a default dummy implementation
in xc_private.c with __attribute__ ((weak)). If you have only a function
prototype in xc_private.h then you won't need -D_GNU_SOURCE for
xcutil/Makefile.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel