[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] [XEN] [ACM] Simplify the event channel scanning


  • To: Stefan Berger <stefanb@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Tue, 27 Feb 2007 19:02:36 +0000
  • Delivery-date: Tue, 27 Feb 2007 11:01:56 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdaodfLFoYi7saVEduLoQAX8io7RQ==
  • Thread-topic: [PATCH] [XEN] [ACM] Simplify the event channel scanning

On 27/2/07 17:19, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> This patch simplifies the scanning of a domain's event channels
> considering that an 'ECS_UNBOUND' event channel is not connected and can
> be skipped.
> 
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

This code is still broken: you are checking only the first event-channel in
each bucket. You need a double loop: the new inner loop should iterate from
0 to EVTCHNS_PER_BUCKET-1.

ports = d->evtchn[bucket];
If ( ports == NULL )
    break;
for ( j = 0; j < EVTCHNS_PER_BUCKET; j++ )
  .... process ports[j] ....

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.