[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] hvm_init_ap_contexts


  • To: "PUCCETTI Armand" <armand.puccetti@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
  • Date: Thu, 1 Mar 2007 17:49:41 +0100
  • Delivery-date: Thu, 01 Mar 2007 08:57:38 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdcIMXqxyCLH34bQKKPS/Kot+of1gAADXNA
  • Thread-topic: [Xen-devel] hvm_init_ap_contexts

 

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> PUCCETTI Armand
> Sent: 01 March 2007 16:43
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] hvm_init_ap_contexts
> 
> Why is there an argument returned in the function below (of hvm.h), 
> knowing that there is void?
> 
> static inline void
> hvm_init_ap_context(struct vcpu_guest_context *ctxt,
>                    int vcpuid, int trampoline_vector)
> {
>    return hvm_funcs.init_ap_context(ctxt, vcpuid, trampoline_vector);
> }

Seems broken (or rather "unnecessar and confusing" to me - fancy
submitting a fix?

>From what I can tell, this has been "broken" for quite some time, and as
of about 2000 changesets, the return-type of that function hasn't
changed. 

--
Mats
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.