[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] page ownership

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Thu, 08 Mar 2007 10:23:15 +0000
  • Delivery-date: Thu, 08 Mar 2007 02:22:30 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acdha8gbBudSdM1fEduQtwAX8io7RQ==
  • Thread-topic: [Xen-devel] page ownership

On 8/3/07 10:10, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Is there a particular reason why page_set_owner(pg, NULL) is
> - not used in free_domheap_pages()?

It's done in __alloc_domheap_pages() instead. Arguably moving it would be

> - only used on pages 1 ... ((1 << order) - 1) in __alloc_domheap_pages()?

Page 0 is done outside the loop, and writes directly to _domain for no
particularly good reason. I guess I implemented the first iteration outside
the loop to special-case initialisation of the tlbflush cpumask. Which
probably isn't a very worthwhile optimisation, to be honest.

I'll do a little cleanup here. It would certainly be sane to not have random
domain pointers hanging around in freed pages.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.