[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] return value checking on multicalls

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 14 Mar 2007 16:00:12 +0000
  • Delivery-date: Wed, 14 Mar 2007 08:59:35 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdmUdjbF2+ksdJFEdu8zgAX8io7RQ==
  • Thread-topic: [Xen-devel] return value checking on multicalls

On 14/3/07 15:55, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Many places currently don't even check HYPERVISOR_multicall()'s return
> value, not to speak of checking the individual status codes. Would it be
> acceptable to add an argument to this function to request to either fold
> all status values into a global success code, or to force BUG_ON() each
> individual status. Or should I rather add a new function with described
> behavior? Or are there other suggestions?

I think a separate function would be neater, but I'm not sure what you'd
call it. :-) The general idea seems a good one.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.