[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [HVM] Patches to make HVM capable of running OS/2.


  • To: "Keir Fraser" <keir@xxxxxxxxxxxxx>
  • From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
  • Date: Fri, 16 Mar 2007 21:11:00 +0100
  • Cc: Mats.Petersson@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, thomas.woller@xxxxxxx
  • Delivery-date: Fri, 16 Mar 2007 13:10:00 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=D67lJ7AyJUWZTnTJQyUDh+ETOD7OA8JRR3zyrHcCcZfJ4CKwcawO1iozFmKgK+Vs8CrNRWAqO0HnKicHzsqrPjdZzv9SXC1776beCISes28/kxHAjGf/cynyG+xodiY7144xgycYkT7ZRJFJoeXLfUmkWjJVm1EwPOy38XnMvwc=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Meanwhile, domUs have plenty of other shared-memory protocols with dom0 kernel and root processes. It just needs some care to make sure the interface is sufficiently narrow and arguments are well checked. Burning 100% CPU is not considered a successful attack (although it would of course be annoying!). You can detect it and fix it up without rebooting the system, for example.

Indeed, that one is very easy to guard against in the code, too. Simply making the iopage handler loop on <= instead of != would do it, although it's probably better to just insert a sanity before entering the loop, and printing a warning to the log that the iopage may have been corrupted if bad values are detected.
In any case, the current "qemu-dm in dom0" device model is unlikely to live forever. Both the two future alternatives I've seen discussed - the stub domain and the "reflection" one suggested earlier this month - would do away with any concerns I have. With the "reflection" model, the device emulation would actually run inside the HVM, in which case the io pages should certainly be owned by the domU, and in the stub domain case, I suppose it wouldn't matter as much whether the domU or the stub domain owned the pages in any case.

All your other patches are in except the smsw one.

Great news.

I'm looking at that now.

I apologize to your eyes, and hope it won't ruin your weekend. ;)
That one shouldn't go in in its current state, at least.

/Trolle
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.