[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] remove redundant rcu_read_unlock

In the function rcu_lock_domain_by_id there is a call to
rcu_read_unlock just prior to returning. However, the intent is that
the rcu reader retain the read lock after the call has returned. This
can be verified by auditing the callers of this routine, which each
explicitly call rcu_unlock_domain, which in turn calls

Remove redundant call to rcu_read_unlock.

signed-off-by: Mike D. Day <ncmike@xxxxxxxxxx>

diff -r 6ee683d1b61f xen/common/domain.c
--- a/xen/common/domain.c       Wed Mar 28 15:31:17 2007 +0100
+++ b/xen/common/domain.c       Wed Mar 28 14:43:13 2007 -0400
@@ -252,8 +252,6 @@ struct domain *rcu_lock_domain_by_id(dom
            return d;

-    rcu_read_unlock(&domlist_read_lock);
    return NULL;

Mike D. Day
Cell: 919 412-3900
Sametime: ncmike@xxxxxxxxxx AIM: ncmikeday  Yahoo: ultra.runner
PGP key: http://www.ncultra.org/ncmike/pubkey.asc

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.