[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: lock issue for vpic_irq_negative_edge


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Thu, 29 Mar 2007 15:39:01 +0800
  • Delivery-date: Thu, 29 Mar 2007 00:38:16 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acdxq2rwPOuYrZ93SlCRhY9uMvANXwAKTL/TAAAiJ4A=
  • Thread-topic: lock issue for vpic_irq_negative_edge

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年3月29日 15:34
>
>On 29/3/07 03:39, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> Hi, Keir,
>> vPIC has a private lock, but there's no acquisition in the
>> injection
>> path. This should be a potential issue for change on IRR. Then the
>> assertion (ASSERT(vpic_is_locked(vpic)) is likely to be failed within
>> vpic_irq_negative_edge if debug option is enabled. Is anything
>> missing here?
>
>No, there actually isn't a private vPIC lock any more. If you look at the
>top of the vpic.c file you'll see that the 'vpic lock' is actually an alias
>for the generic irq_lock. This is always acquired by the caller of
>vpic_irq_negative_edge().
>
> -- Keir
>

Oh, yes, my mistake on position of parenthesis. :-)
Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.