[Xen-devel] Re: [PATCH][RFC] Emulating real mode with x86_emulate

["Kamble, Nitin A" <nitin.a.kamble@xxxxxxxxx>]

On Fri, 2007-03-30 at 15:11 -0700, Anthony Liguori wrote:

>     set_cr0 is returning 1 though which should increment eip to the next
>     instruction.
>     
>     I'm a bit perplexed about my eip now and also why your eip is still 0. 
>     It should be the instruction following the mov cr0.
>     
>     Regards,
>     
>     Anthony Liguori
>     

Hi Anthony,
    I don't see any code doing context save/restore like vmx_world_save , vmx_world_restore in the current code for the hyperviser based emulator.
Also the function  arch_vmx_do_resume() is called at the time of vcpu schedule, so it is not right to call the  vmx_do_emulate() from there.

The code would need vmx_world_save/restore in the code path before returning to vmx_asm_vmexit_handler from vmx_vmexit_handler.
Without that I don't see it can emulate any instructions.

Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation.
-------------------------------------------------------------------------
The mind is like a parachute; it works much better when it's open.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel