Re: [Xen-devel] [PATCH] linux: simplify and perform checking of multicall status

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir@xxxxxxxxxxxxx> 05.04.07 10:29 >>>
>On 26/3/07 15:54, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> +static inline int
>> +HYPERVISOR_multicall_check(
>> + multicall_entry_t *call_list, int nr_calls,
>> + const unsigned long *rc_list)
>> +{
>> + int rc = HYPERVISOR_multicall(call_list, nr_calls);
>> +
>> + if (unlikely(rc == 0))
>> +  return rc;
>
>ITYM unlikely(rc != 0)?

Huh, indeed. And perhaps it should (give the rest of the function) even
be

        if (unlikely(rc < 0))
                return rc;
        BUG_ON(rc);

(i.e. so that positive return values indicate the failed slot, negative ones
indicate a failure of the multicall itself).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel