[Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table)

["KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>]

Hi Keir,

>>>>> On Wed, 11 Apr 2007 15:27:53 +0100
>>>>> keir@xxxxxxxxxxxxx(Keir Fraser)  said:
> 
> On 11/4/07 08:48, "Takahashi Tomohiro" <takatom@xxxxxxxxxxxxxx> wrote:
> 
> > I made a patch for GPT support.
> 
> I don't see anything wrong with it, although won't it always be the first
> legacy partition that is marked with type 0xee?

No, but this patch supports the second (or third, ...) legacy
partition marked with 0xee.
# I have no idea whether it is necessary well...

This patch has different problems. get_active_partition() returns a
entry of a legacy partition. Since the structure of GPT partition
entries differs from the structure of legacy partition entries, this
patch has the following problem:

 - pygrub cannot access a domain more than 2^32 * SECTOR_SIZE because
   get_fs_offset() treats the offset as a 32-bit integer. In GPT, the
   offset must be treated as 64-bit integer.

 - This patch returns a part of a GUID unique to the partition as
   legacy partition types. pygrub may misunderstand partition types.

I plan to fix this problem.

Best Regards,
-- 
  KUWAMURA Shin'ya

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel