Re: [Xen-devel] [PATCH] netfront: Lockdep fixes

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13/4/07 13:10, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> The ->poll method is guaranteed to be called with BH disabled so
> this isn't necessary.

Thanks.

>> @@ -1588,7 +1588,7 @@ static void netif_release_rx_bufs(struct
> 
> Just a minor nit.  This is normally called with BH disabled,
> except from uninit so you could put a local_bh_disable there
> instead.

That function's *only* called from uninit()!

> You can't enable BH with IRQs disabled.  Besides, for the sake of
> symmetry these two should be reversed.

Ack, I should have spotted this one, and the ditto.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel