[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Clear VMCS if reusing after vcpu reset


  • To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 30 Apr 2007 07:41:12 +0100
  • Delivery-date: Sun, 29 Apr 2007 23:38:05 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceK7hrJaVpsNFsWQeu9LhE5uBSFagABHAUj
  • Thread-topic: [Xen-devel] [PATCH] Clear VMCS if reusing after vcpu reset



On 30/4/07 07:09, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Clear whole page when VMCS is reused due to cpu hotplug.
> construct_vmcs doesn't take care of all fields and some stale
> content may make hardware unhappy.
> 
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>

Which hotplug would that be? I can't see how vmx_create_vmcs() can be called
more than once for any vcpu. It's called during vcpu creation and that's it
afaics. The current check for v->arch.hvm_vmx.vmcs==NULL is therefore
redundant.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.