Re: [Xen-devel] [PATCH] [Xen-API] Patch for fixing the rtc/timeoffset entry

[Stefan Berger <stefanb@xxxxxxxxxx>]

A simpler solution below:


  Signed-off-by: Stefan Berger
<stefanb@xxxxxxxxxx>

  Stefan

diff -r 3a5722420de7 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py        
        Thu May 03 19:25:47 2007 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py        
        Mon May 07 16:33:14 2007 -0400
@@ -868,6 +868,9 @@ class XendDomainInfo:
         # convert two lists into a python dictionary
         vm_details = dict(zip(cfg_vm, vm_details))
         
+        if vm_details['rtc/timeoffset'] == None:
+            vm_details['rtc/timeoffset']
= "0"
+        
         for arg, val in vm_details.items():
             if arg in XendConfig.LEGACY_CFG_TO_XENAPI_CFG:
                 xapiarg = XendConfig.LEGACY_CFG_TO_XENAPI_CFG[arg]




Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote
on 05/07/2007 09:01:59 AM:

> On 5/5/07 15:42, "Stefan Berger" <stefanb@xxxxxxxxxx>
wrote:
> 
> > This patch rewrites the rtc/timeoffset entry so the VM's record
can be
> > retrieved with the Java xmlrpc library. If the entry is 'None'
it upsets
> > the xmlrpc parser. This fixes it, though maybe there's a better
place in
> > xend to place similar code.
> 
> Can't the second argument to vm_details.get() be changed to "0"?
If not,
> could you just do 'foo = vm_details.get(...) or "0"'?
> 
>  -- Keir
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel