[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules
On 8/5/07 10:54, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote: > 3/4: Frontend net driver acceleration > - this provides hooks in the netfront driver to allow a plugin module > to attach and be called at appropriate points. > > 4/4: Backend net driver acceleration > - this provides hooks in the netback driver to allow a plugin module to > attach and be called at appropriate points. These probably should be reviewed by someone like Herbert Xu for sanity. I can immediately see that Linux coding style is not followed (lack of spaces around if(){, and LOUD MACROS are two problems I can see). netfront_stop_queue and friends look like pointless wrappers. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |