[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules


  • To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 08 May 2007 11:43:47 +0100
  • Delivery-date: Tue, 08 May 2007 03:42:24 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceRXcGiABTiCf1REduQdAAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules

On 8/5/07 10:54, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

> 3/4:  Frontend net driver acceleration
>  - this provides hooks in the netfront driver to allow a plugin module
> to attach and be called at appropriate points.
> 
> 4/4:  Backend net driver acceleration
>  - this provides hooks in the netback driver to allow a plugin module to
> attach and be called at appropriate points.

These probably should be reviewed by someone like Herbert Xu for sanity. I
can immediately see that Linux coding style is not followed (lack of spaces
around if(){, and LOUD MACROS are two problems I can see).
netfront_stop_queue and friends look like pointless wrappers.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.